Seek to beginning of IOBuffer before returning it #212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It’s impossible to read from an IOBuffer that was just written to: its position is set to its end and reading from it results in EOFError.
|
@ikirill Do we need to merge this? |
|
An IOStream and IOBuffer are incompatible types |
|
So close this? |
vtjnash
reviewed
Oct 20, 2022
Comment on lines
116
to
+119
| function Base.convert(::Type{IOStream}, zmsg::Message) | ||
| s = IOBuffer() | ||
| write(s, zmsg) | ||
| seek(s, 0) |
There was a problem hiding this comment.
Suggested change
| function Base.convert(::Type{IOStream}, zmsg::Message) | |
| s = IOBuffer() | |
| write(s, zmsg) | |
| seek(s, 0) | |
| function Base.convert(::Union{Type{IO},Type{IOBuffer}}, zmsg::Message) | |
| s = IOBuffer() | |
| write(s, zmsg) | |
| seekstart(s) |
|
I am not sure, but |
|
I'm with @vtjnash here, it seems like a bug (or at least a footgun) that
@ikirill, are you able to finish the PR? I can if not. |
|
@ikirill doesn't seem to be too active in the last year. |
|
Hi! I don't remember anything about this PR at this point, and I gave up on trying to use ZeroMQ a very long time ago. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It’s impossible to read from an IOBuffer that was just written to: its
position is set to its end and reading from it results in EOFError.